-
Notifications
You must be signed in to change notification settings - Fork 233
Only use the official Gherkin parser objects and remove custom parser logic #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use the official Gherkin parser objects and remove custom parser logic #699
Conversation
…n public API and current codebase as much as possible)
…f available data and implementing features.
…s removing tabbing from docstring in steps (aka multiline steps)
|
I'm thinking a different approach might be better to keep the DAO/mapping and logic encapsulated |
…cessing where not needed
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
youtux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Closed to focus on parser, and ended up just dumping things I was trying on this branch - apologies! |
Going a step further than my previous PR that simply parsed the feature files using the official parser, but then copied this data into the existing parser objects, this PR removes the old parser completely and either uses the data directly that is parsed into the models from the Gherkin parser or adds needed functionality to the Gherkin parser models to enhance just being DAOs for pytest-bdd to use the data as it needs to.