Fixes py.path.local.samefile in Python 3 on Windows #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 on Windows contains a working implementation of os.path.samefile that should be used.
6 tasks
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Dec 26, 2019
As discussed in pytest-dev#6159, we are waiting for a new py release (pytest-dev/py#229)
RonnyPfannschmidt
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 on Windows contains a working implementation of os.path.samefile that should be used.
Discovered this while investigating why
test_cmdline_python_package_symlinkfails on Python 3.8 on Windows (pytest-dev/pytest#6159).