DeprecationWarning: 'U' mode is deprecated

[montefra]

From python 3.4 on, the 'U' mode of open has been deprecated.
According to this answer the 'U' has been replaced by the newline argument, that when set to None, the default, uses universal new line.
I have identified only three rU modes. Two in the readline function and one regarding svn.

• If it's fine with you, for the first two cases I'll do a PR where I set the mode to rU for python 2 and r otherwise.
• I don't think that I need to touch the svn case, as the mode is never used

[RonnyPfannschmidt]

Since Python 3.3 is in the support Matrix, does that work the same?

[montefra]

It seems so: https://docs.python.org/3.3/library/functions.html#open.

The newline argument is present and

'U' universal newlines mode (for backwards compatibility; should not be used in new code)

[RonnyPfannschmidt]

The PR you propose is def an enhancement

we will have to follow up with open and read eventially tho

[montefra]

I can start with readlines and then work my way through.
I discovered the deprecation through pytest-warnings and I think that I can temporarily enable it to check. I'll start the PR early next week

[RonnyPfannschmidt]

closed by #116