Typing prep #189
Merged
Typing prep #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `id` here referred to the builtin `id` function, that's not the intention.
The gevent one is wrong (should be `gevent.threading`), which made it clear it's not used at all.
`execmodel.WorkerPool` creates an unneeded dependency cycle. And it's not any better than the alternative really. `execmodel.PopenPiped` is a convenience that's not really needed at the abstraction layer, clearer to just inline it to the one place it's used.
Not used since 120f639.
Member
|
im hoping we can remove execmodel sooner or later as its actively hostile to asyncio based implementation for a number of details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small internal refactoring commits in preparation for adding type annotations. The bigger changes are rewriting some clever hpk42-style code that unfortunately can't be statically analyzed (I have a pending change to also improve ExecModel in this regard).