Skip to content

Implement PEP 658 #13649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 11, 2023
Merged

Implement PEP 658 #13649

merged 8 commits into from
May 11, 2023

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented May 11, 2023 •
edited
Loading 

chungus:~ ee$ curl localhost/simple/pip/
<!DOCTYPE html>
<html>
  <head>
    <meta name="pypi:repository-version" content="1.1">
    <title>Links for pip</title>
  </head>
  <body>
    <h1>Links for pip</h1>
<!--snip--!>
    <a href="http://localhost:9001/packages/c2/d7/90f34cb0d83a6c5631cf71dfe64cc1054598c843a92b400e55675cc2ac37/pip-18.1-py2.py3-none-any.whl#sha256=7909d0a0932e88ea53a7014dfd14522ffef91a464daaaf5c573343852ef98550" data-requires-python="&gt;=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*" >pip-18.1-py2.py3-none-any.whl</a><br />
    <a href="http://localhost:9001/packages/45/ae/8a0ad77defb7cc903f09e551d88b443304a9bd6e6f124e75c0fbbf6de8f7/pip-18.1.tar.gz#sha256=c0a292bd977ef590379a3f05d7b7f65135487b67470f6281289a94e015650ea1" data-requires-python="&gt;=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*" >pip-18.1.tar.gz</a><br />
    <a href="http://localhost:9001/packages/08/e3/57d4c24a050aa0bcca46b2920bff40847db79535dc78141eb83581a52eb8/pip-23.1.2-py3-none-any.whl#sha256=3ef6ac33239e4027d9a5598a381b9d30880a1477e50039db2eac6e8a8f6d1b18" data-requires-python="&gt;=3.7" data-dist-info-metadata="sha256=25d28eaaf301f86bcbe98aa5a73563f067595934bd31c759975660aed4841b5b">pip-23.1.2-py3-none-any.whl</a><br />
</body>
</html>
<!--SERIAL 582415-->

chungus:~ ee$ curl -s -H"Accept: application/vnd.pypi.simple.v1+json" localhost/simple/pip/ | jq '.'
{
  "files": [
#snip
    {
      "data-dist-info-metadata": false,
      "filename": "pip-18.1-py2.py3-none-any.whl",
      "hashes": {
        "sha256": "7909d0a0932e88ea53a7014dfd14522ffef91a464daaaf5c573343852ef98550"
      },
      "requires-python": ">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",
      "size": 1323545,
      "upload-time": "2018-10-05T11:21:11.431291Z",
      "url": "http://localhost:9001/packages/c2/d7/90f34cb0d83a6c5631cf71dfe64cc1054598c843a92b400e55675cc2ac37/pip-18.1-py2.py3-none-any.whl",
      "yanked": false
    },
    {
      "data-dist-info-metadata": false,
      "filename": "pip-18.1.tar.gz",
      "hashes": {
        "sha256": "c0a292bd977ef590379a3f05d7b7f65135487b67470f6281289a94e015650ea1"
      },
      "requires-python": ">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",
      "size": 1259370,
      "upload-time": "2018-10-05T11:21:24.028561Z",
      "url": "http://localhost:9001/packages/45/ae/8a0ad77defb7cc903f09e551d88b443304a9bd6e6f124e75c0fbbf6de8f7/pip-18.1.tar.gz",
      "yanked": false
    },
    {
      "data-dist-info-metadata": {
        "sha256": "25d28eaaf301f86bcbe98aa5a73563f067595934bd31c759975660aed4841b5b"
      },
      "filename": "pip-23.1.2-py3-none-any.whl",
      "hashes": {
        "sha256": "3ef6ac33239e4027d9a5598a381b9d30880a1477e50039db2eac6e8a8f6d1b18"
      },
      "requires-python": ">=3.7",
      "size": 2064688,
      "upload-time": "2023-05-11T16:45:36.408827Z",
      "url": "http://localhost:9001/packages/08/e3/57d4c24a050aa0bcca46b2920bff40847db79535dc78141eb83581a52eb8/pip-23.1.2-py3-none-any.whl",
      "yanked": false
    }
  ],
  "meta": {
    "_last-serial": 582415,
    "api-version": "1.1"
  },
  "name": "pip",
  "versions": [
    "8.0.0.dev0",
    "10.0.0b2",
    "10.0.0",
    "10.0.1",
    "18.0",
    "18.1",
    "23.1.2"
  ]
}

chungus:~ ee$ curl -s http://localhost:9001/packages/08/e3/57d4c24a050aa0bcca46b2920bff40847db79535dc78141eb83581a52eb8/pip-23.1.2-py3-none-any.whl.metadata
Metadata-Version: 2.1
Name: pip
Version: 23.1.2
Summary: The PyPA recommended tool for installing Python packages.
Home-page: https://pip.pypa.io/
Author: The pip developers
Author-email: [email protected]
License: MIT
Project-URL: Documentation, https://pip.pypa.io
Project-URL: Source, https://github.com/pypa/pip
Project-URL: Changelog, https://pip.pypa.io/en/stable/news/
...#snip

@ewdurbin ewdurbin requested a review from a team as a code owner May 11, 2023 17:35
@ewdurbin
Copy link
Member Author

ewdurbin commented May 11, 2023 •
edited
Loading

Picks up from/closes #9972. End-to-end implementation of PEP 658.

Closes: #8254

ewdurbin
ewdurbin commented May 11, 2023
View reviewed changes
@ewdurbin ewdurbin force-pushed the implement_pep_658 branch from b98d020 to d85432e Compare May 11, 2023 17:55
@ewdurbin ewdurbin mentioned this pull request May 11, 2023
Merged
@ewdurbin ewdurbin merged commit a11df56 into main May 11, 2023
@ewdurbin ewdurbin deleted the implement_pep_658 branch May 11, 2023 19:24
@ewdurbin ewdurbin mentioned this pull request May 11, 2023
Closed
@pradyunsg
Copy link
Contributor

Thank you for doing this! ❤️

@abitrolly
Copy link
Contributor

Thank you for doing this! ❤️

@pradyunsg copying my code and erasing all notion my contribution. Also not addressing the blocker with .zip bombs that people told me to address.

I am very disappointed. After all the time I spent on that, trying to find funding to solve it, I get this.

@woodruffw woodruffw mentioned this pull request May 12, 2023
Closed
@ewdurbin ewdurbin mentioned this pull request May 20, 2023
Closed
@EpicWink EpicWink mentioned this pull request May 22, 2023
Closed
@bm371613 bm371613 mentioned this pull request Aug 17, 2023
Closed
2 tasks
@cosmicexplorer cosmicexplorer mentioned this pull request Sep 3, 2023
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstufft dstufft dstufft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ewdurbin @pradyunsg @abitrolly @dstufft