Remove "residual" dependencies from setup.py when dependencies are set in pyproject.toml
#3306
Conversation
This is discussed in issue 3300.
|
|
||
| def _dependencies(dist: "Distribution", val: list, _root_dir): | ||
| existing = getattr(dist, "install_requires", []) | ||
| _set_config(dist, "install_requires", existing + val) |
There was a problem hiding this comment.
Unless I'm reading PEP 621 wrong, couldn't dependencies also be one of the keys that can be specified as dynamic? Wouldn't this always overwrite?
There was a problem hiding this comment.
Hi @nullableVoidPtr thank you very much for the review. It is very appreaciated!
Yes, that is correct, dynamic can contain dependencies. But in that case the dependencies key cannot be present in the project table (according to PEP 621, a key can only be specified either statically or dynamically, never both -- this should enforced during the validation phase).
In turn, this means that the _dependencies function will not be called (line 66 of setuptools/config/_apply_pyprojecttoml.py). Right?
There was a problem hiding this comment.
Ah yep, all good; wasn't looking at the bigger picture 😅 LGTM
2 participants
Summary of changes
pyproject.tomlnow completely overwritesetup.py install_requires.For the time being, no action is taken on
optional-dependencies, because of the internal mechanism setuptools uses for handling environment markers (internally environment markers are transformed inextrasso we need to merge existing optional dependencies to the ones given inpyproject.toml, see #3223).Closes #3300
Pull Request Checklist
changelog.d/.(See documentation for details)