Skip to content

Conversation

@leekillough
Copy link

@leekillough leekillough changed the title Undo preserve_move=False in order to preserve execute permission Undo preserve_mode=False in order to preserve execute permission Mar 24, 2020
@jorikdima
Copy link
Contributor

I suggest not to undo, but make this fix better. I am working on the PR

@jaraco
Copy link
Member

jaraco commented Mar 24, 2020

Thanks jorikdima. As is revealed by the Appveyor tests, this change causes a test to fail on Windows, a test we put in place to protect the requirement that inspired the change. I would similarly like to see a test to capture the (untested) expectation that this PR is attempting to restore.

@leekillough
Copy link
Author

I'm fine with a "correct" fix -- this was just a short-term stop-gap solution.

Let's fix the original issue(s), as well as the regression caused by the lack of execution bits being preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaged script execute permissions lost from v46.1.0 onwards

3 participants