Add version_tuple to write_to contents #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Sep 2, 2020
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jun 14, 2021
This adds `pytest.version_tuple`, which makes it simpler for users to do something depending on the pytest version (such as declaring plugins which are introduced in later versions) more easily than parsing the version themselves. This feature was added originally in pypa/setuptools-scm#475. Followup to pytest-dev#7605.
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jun 14, 2021
This adds `pytest.version_tuple`, which makes it simpler for users to do something depending on the pytest version, such as declaring hooks which are introduced in later versions. This feature was added originally in pypa/setuptools-scm#475. Followup to pytest-dev#7605.
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jun 14, 2021
This adds `pytest.version_tuple`, which makes it simpler for users to do something depending on the pytest version, such as declaring hooks which are introduced in later versions. This feature was added originally in pypa/setuptools-scm#475. Followup to pytest-dev#7605.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to keep things simple and parsing the final string instead of changing
dump_versionto receive and handle aScmVersionobject, as that entails also dealing with configuration options related to how interpret/format that version, but let me know if you want this implemented in another way. 👍Fix #469