fix: allow HTML5 s tag through cleaner #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pypa#261 Signed-off-by: Mike Fiedler <[email protected]>
1 task
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Nov 11, 2022
When Pygments renders HTML, t uses the `<s>` tag for string literals, which most browsers will interpret as a Strikethrough, which is confusing. Introduced during a fix for pypa/readme_renderer#262 and surfaced in project pages since. Fixes: pypi#12484 Signed-off-by: Mike Fiedler <[email protected]>
di
added a commit
to pypi/warehouse
that referenced
this pull request
Nov 11, 2022
When Pygments renders HTML, t uses the `<s>` tag for string literals, which most browsers will interpret as a Strikethrough, which is confusing. Introduced during a fix for pypa/readme_renderer#262 and surfaced in project pages since. Fixes: #12484 Signed-off-by: Mike Fiedler <[email protected]> Signed-off-by: Mike Fiedler <[email protected]> Co-authored-by: Dustin Ingram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
Signed-off-by: Mike Fiedler [email protected]