Skip to content

Allow using a custom Python interpreter to run the PEP517 hooks #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2020
Merged

Allow using a custom Python interpreter to run the PEP517 hooks #93

merged 1 commit into from
Oct 18, 2020

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Sep 15, 2020

Signed-off-by: Filipe Laíns [email protected]

@FFY00
Copy link
Member Author

FFY00 commented Sep 15, 2020

See #92

@FFY00
Copy link
Member Author

FFY00 commented Sep 15, 2020

Ops, fixed the error on Python 2.

gaborbernat
gaborbernat approved these changes Oct 13, 2020
View reviewed changes
Copy link

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat
Copy link

gaborbernat commented Oct 13, 2020

@takluyver can we can a release cut with this please?

@gaborbernat gaborbernat mentioned this pull request Oct 13, 2020
Merged
@pradyunsg
Copy link
Member

pradyunsg commented Oct 13, 2020

With #96 merged, I think we can indeed! I don't have the release bit -- but whoever cuts the release, please do review the changelog before making the release.

@takluyver takluyver merged commit d949df3 into pypa:master Oct 18, 2020
@takluyver takluyver mentioned this pull request Oct 18, 2020
Closed
@takluyver
Copy link
Member

takluyver commented Oct 18, 2020

Out now as 0.9, and we even have a changelog now: https://pep517.readthedocs.io/en/latest/changelog.html

BTW, this project is set up (thanks to @jaraco ) so that anyone who can push to master can also release it - use bump2version to commit & tag a new version number, push it, and Travis CI uploads the release to PyPI. Feel freet to use that ability so I'm not a bottleneck. :-)

@gaborbernat gaborbernat mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoore pfmoore pfmoore approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

+1 more reviewer

@gaborbernat gaborbernat gaborbernat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FFY00 @gaborbernat @pradyunsg @takluyver @pfmoore