Skip to content

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 9, 2021

  • tests
  • changelog

sbidoul added 5 commits July 10, 2021 13:53
Factor out the wheel building operation so the
metadata extraction logic can be resused
for editables.
So we get a precise exception when prepare_metadata_for_build_editable
fallback fails due to a missing build_editable hook.
@sbidoul
Copy link
Member Author

sbidoul commented Jul 10, 2021

This should be ready for review/comments.

It is mostly a straightforward copy of the wheel hooks, with a small difference in the prepare_metadata_for_build_editable fallback in case the build_editable hook is missing.

Do not merge just yet as I'll do more integration testing with pip.

@sbidoul sbidoul marked this pull request as ready for review July 16, 2021 16:48
@sbidoul
Copy link
Member Author

sbidoul commented Jul 16, 2021

I did further testing with pip. This should be good for merging.

@takluyver takluyver merged commit e97bd1d into pypa:master Jul 18, 2021
@takluyver
Copy link
Member

Thanks @sbidoul !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants