Check Requires-Python before other dependencies #9994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
May 29, 2021
webknjaz
approved these changes
May 29, 2021
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
This is nice. Do you want to add a test ensuring that no other checks happen once there's a Python version mismatch?
This makes the resolver fail quicker when there's a interpreter version conflict, and avoid additional (useless) downloads.
uranusjr
force-pushed
the
requires-python-before-other-deps
branch
from
2bbf7b4 to
c8638ad
Compare
Member
Author
|
Test added. I also changed the implementation to use |
pradyunsg
approved these changes
Jun 1, 2021
xavfernandez
approved these changes
Jun 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the resolver fail quicker when there's a interpreter version conflict, and avoid additional (useless) downloads.
Fix #9925.