Set strict_timestamps=False when zip is called for isolated environment #9920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nicholasserra
changed the title
uranusjr
requested changes
Apr 30, 2021
Co-authored-by: Tzu-ping Chung <[email protected]>
Contributor
Author
|
News file has been changed |
Member
|
Unfortunately this missed the 21.1.1 deadline. I think this counts as regression, so we’ll probably need a 21.1.2 (cc @sbidoul). |
sbidoul
approved these changes
May 3, 2021
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
The change LGTM.
I'm really curious to understand the root cause.
Does this alone warrant a bugfix release ?
Member
|
Yes, not urgent, but this should detinitely be in one of the 21.1 releases eventually. |
|
Don't mind me, continue doing your great work for the Python community - but do you have any sense of when 21.1.2 would be released? This month? June? Or just later this year? |
Member
|
Likely this month |
uranusjr
requested changes
May 9, 2021
Co-authored-by: Tzu-ping Chung <[email protected]>
sbidoul
approved these changes
May 21, 2021
uranusjr
approved these changes
May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9910
Set strict_timestamps=False when using ZipFile for new isolated environment installs. Was triggering an inconsistent ValueError('ZIP does not support timestamps before 1980') on GitHub package installs.
https://docs.python.org/3/library/zipfile.html#zipfile-objects