Skip to content

Conversation

@minrk
Copy link
Contributor

@minrk minrk commented Jan 13, 2021

verbosity level 1 sets subprocess log level to debug (showing subprocess output), while level 2 sets all logging to debug-level. This solves the common problem of disabling suppression of setup.py output without being buried in debug output of getting dependencies from PyPI. Closes #8856.

requires -vv to enable full debug-level output, which is the current behavior of -v.

It would map more naturally to the multi-level -vvv to have more than one two log levels, as -vv currently produces exactly the same output as -v, as far as I can tell. But I expect that using custom log levels (e.g. 15 for VERBOSE) is probably not preferred? The python docs argue pretty strongly against custom log levels, but they are supported, if that seems better.

TODO:

  • assign PR number to news file (need to open PR first!)
  • update any affected tests
  • decide if custom log level is preferred

@minrk minrk force-pushed the v-show-stdout branch 2 times, most recently from 4542a2e to 7579638 Compare January 13, 2021 09:50
by setting only the subprocess log level to debug

require -vv to enable full debug output
@minrk
Copy link
Contributor Author

minrk commented Jan 13, 2021

Looking at the failing tests, I think this is resulting in undesirable behavior for commands other than install, since -v does nothing if no subprocesses are called. I think a custom log level approach (#9450) makes more sense and matches the expectation established by the -v[v] CLI much better.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@minrk
Copy link
Contributor Author

minrk commented Jun 11, 2021

Closing in favor of #9450

@minrk minrk closed this Jun 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs rebase or merge PR has conflicts with current master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable capture of stdout coming from setup.py

2 participants