Skip to content

Conversation

@pradyunsg
Copy link
Member

🌈

This is obviously not optimized and will make log files a bit bigger, but any opinions against this (given that we're not printing the "state" table)?

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes C: new resolver labels Sep 24, 2020
@uranusjr
Copy link
Member

Looks good for me.

@pfmoore
Copy link
Member

pfmoore commented Sep 24, 2020

Maybe only install the reporter if the logging level indicates it's needed? Would that make a difference in performance? I'm a little worried about introducing unnecessary overhead when people are already complaining about speed.

But otherwise this LGTM

@pradyunsg
Copy link
Member Author

Ah mypy. :)

@uranusjr
Copy link
Member

Maybe only install the reporter if the logging level indicates it's needed? Would that make a difference in performance?

Good idea IMO. The logging module is known to be slow.

@pradyunsg
Copy link
Member Author

Closing since #9017 adds a reporter, and adding this would cause merge conflicts that I don't wanna deal with. :)

@pradyunsg pradyunsg closed this Oct 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants