Apply _internal.utils.appdirs changes to _vendor.appdirs #7501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Err, sorry, I intended to post this as a draft but forgot. Now I don’t know how to change the setting :( |
uranusjr
force-pushed
the
appdirs-patch
branch
2 times, most recently
from
c6c83e3 to
8e06859
Compare
* Convert Windows app data directory values to bytes on Python 2, so the output type is consistent across platforms (pypa#4000) * Also look in ~/.config for user config on macOS (pypa#4100) * Remove pywin32 dependency, only use ctypes and winreg for directory lookup on Windows (pypa#2467) * Always use os.path.join() instead of os.sep.join() so cross-platform tests work as expected (pypa#3275)
uranusjr
force-pushed
the
appdirs-patch
branch
from
8e06859 to
204887d
Compare
Member
No worries -- you can't change a "normal" PR into a draft one.
Let's do separate PRs for them? |
chrahunt
suggested changes
Dec 20, 2019
Member
chrahunt
left a comment
chrahunt
left a comment
There was a problem hiding this comment.
Thank you for doing this! That issue has been around for some time.
I compared the implementations pretty closely and spotted a few differences, the rest looks OK to me.
Co-Authored-By: Christopher Hunt <[email protected]>
uranusjr
force-pushed
the
appdirs-patch
branch
from
732438e to
d841e17
Compare
uranusjr
force-pushed
the
appdirs-patch
branch
from
d841e17 to
f6afa1a
Compare
pradyunsg
added
project: vendored dependency
uranusjr
force-pushed
the
appdirs-patch
branch
from
bda446b to
c98c0ad
Compare
Member
Author
|
I think this is ready for the next round of reviews 📨 |
Member
|
Thanks for tackling this @uranusjr! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_internalcopy is kept for now as a compatibility layer, so the changes are localised around the_vendorchanges.Progress #6040.
Next steps:
_vendorversion (there are few)._vendorversion. Do we need to? I think it’s a good idea because we’d want to detect incompatible upstream changes (like theappauthorthing), but it’s not strictly required since manual check from maintainers is needed anyway.