Skip to content

Revert "Add new option: pip wheel --save-wheel-names (#6377)" #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2019
Merged

Revert "Add new option: pip wheel --save-wheel-names (#6377)" #7420

merged 1 commit into from
Dec 12, 2019

Conversation

@chrahunt
Copy link
Member

@chrahunt chrahunt commented Dec 1, 2019

This reverts commit bcad1b1, reversing
changes made to f864903.

As discussed, we should rethink the interface of this command output as
part of our larger CLI usability review.

In the interim, the same functionality can be achieved using straightforward shell commands.

See:

cc @PatrikKopkan

@chrahunt chrahunt added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Dec 1, 2019
@chrahunt chrahunt marked this pull request as ready for review December 1, 2019 23:32
@pradyunsg
Copy link
Member

I'm on board for this.

@chrahunt chrahunt force-pushed the maint/revert-save-wheel-names branch from 38d8541 to fbd8904 Compare December 2, 2019 03:55
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Dec 3, 2019
@chrahunt
Revert "Add new option: pip wheel --save-wheel-names (pypa#6377)"
be077b8 
This reverts commit bcad1b1, reversing
changes made to f864903.

As discussed, we should rethink the interface of this command output as
part of larger CLI usability review. In the interim, the same
functionality can be achieved using straightforward shell commands.
@chrahunt chrahunt force-pushed the maint/revert-save-wheel-names branch from fbd8904 to be077b8 Compare December 3, 2019 23:58
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Dec 3, 2019
@sbidoul sbidoul mentioned this pull request Dec 12, 2019
Open
@chrahunt
Copy link
Member Author

Thanks for the reviews!

@chrahunt chrahunt merged commit d7eaede into pypa:master Dec 12, 2019
@chrahunt chrahunt deleted the maint/revert-save-wheel-names branch December 12, 2019 23:57
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jan 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbidoul sbidoul sbidoul approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chrahunt @pradyunsg @BrownTruck @sbidoul @xavfernandez @pypa-bot