consolidate vcs link detection

[sbidoul]

While working on #6853 and #6851, it was not immediately obvious to me why not link.is_artifact means it is a VCS link.

So I thought I could make this little readability improvement, by replacing the global is_vcs_url function by a is_vcs property of Link.

[cjerdonek]

This looks like a good simplification. Thanks!

[cjerdonek]

Since with this change this logic is getting duplicated in both is_vcs and is_artifact, I think it would be best if is_artifact is changed to call this method. (And you can move is_vcs before is_artifact so is_artifact is depending on methods defined before it.) Also, that way we avoid introducing a second nested import.

[sbidoul]

Good point. Done.

[chrahunt]

Looks good to me.

[cjerdonek]

Actually, this can just be:

return not self.is_vcs

[sbidoul]

Yes of course, but reading the docstring I had the feeling it was meant to evolve to cover other cases. That is also the reason I refrained of implementing is_vcs as not is_artifact. What do you think?

[cjerdonek]

It's always possible things can change in the future, but we can cross that bridge when we get to it! :)

[cjerdonek]

FWIW, I do agree the current docstring is confusing..

[sbidoul]

Okay, done and squashed.

[cjerdonek]

Great! 👍