Skip to content

Remove copy from tests.lib.path.Path. #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2019
Merged

Remove copy from tests.lib.path.Path. #6746

merged 2 commits into from
Jul 20, 2019

Conversation

@chrahunt
Copy link
Member

Progresses #6050.

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code labels Jul 20, 2019
@chrahunt chrahunt mentioned this pull request Jul 20, 2019
Closed
pradyunsg
pradyunsg approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so much nicer.

@xavfernandez xavfernandez merged commit 0d28601 into pypa:master Jul 20, 2019
@chrahunt chrahunt deleted the maint/remove-path-copy branch July 20, 2019 23:20
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrahunt @xavfernandez @pradyunsg