Skip to content

Fix #6371: make pip install respect --ignore-requires-python #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2019
Merged

Fix #6371: make pip install respect --ignore-requires-python #6518

merged 4 commits into from
May 23, 2019

Conversation

@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 21, 2019

This fixes #6371.

@cjerdonek cjerdonek added C: finder PackageFinder and index related code type: bugfix labels May 21, 2019
@cjerdonek cjerdonek force-pushed the issue-6371-ignore-requires-python branch from 89c9ae8 to 795946e Compare May 21, 2019 19:29
@cjerdonek cjerdonek mentioned this pull request May 21, 2019
Closed
@cjerdonek cjerdonek force-pushed the issue-6371-ignore-requires-python branch from 795946e to d71157e Compare May 22, 2019 16:09
@cjerdonek
Copy link
Member Author

cjerdonek commented May 22, 2019

Rebased after PR #6514.

@cjerdonek cjerdonek force-pushed the issue-6371-ignore-requires-python branch from d71157e to 5b1f797 Compare May 22, 2019 16:21
xavfernandez
xavfernandez approved these changes May 22, 2019
View reviewed changes
src/pip/_internal/index.py Outdated
Copy link
Member

@xavfernandez xavfernandez May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log message could (when read quickly) lead the user to think that the link was ignored.
Maybe 'Ignoring incompatible Requires-Python check result (%s not in: %r) for link: %s' ?

Copy link
Member Author

@cjerdonek cjerdonek May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I went ahead and changed it to:

Ignoring failed Requires-Python check (3.6.5 not in: '== 3.6.4') for link: ...

@cjerdonek cjerdonek force-pushed the issue-6371-ignore-requires-python branch from 5b1f797 to 5528d35 Compare May 23, 2019 04:36
@cjerdonek
Copy link
Member Author

cjerdonek commented May 23, 2019

Thanks for reviewing, @xavfernandez!

@cjerdonek cjerdonek merged commit eeb74ae into pypa:master May 23, 2019
@cjerdonek cjerdonek deleted the issue-6371-ignore-requires-python branch May 23, 2019 05:38
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation C: finder PackageFinder and index related code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--ignore-requires-python has no effect

2 participants

@cjerdonek @xavfernandez