Use shutil.move instead of os.rename #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.rename causes errors to happen whenever the temporary location is on a different device than the wheel cache directory. Using shutil.move instead will cause it to use os.rename when it can and fallback to copying otherwise.
dstufft
added a commit
that referenced
this pull request
May 4, 2015
Use shutil.move instead of os.rename
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.renamecauses errors to happen whenever the temporary location is on a different device than the wheel cache directory. Usingshutil.moveinstead will cause it to useos.renamewhen it can and fallback to copying otherwise.