Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions news/13252.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
When choosing a preferred requirement for resolving dependencies
do not consider a specifier with a * in it, e.g. "==1.*", to be a
pinned specifier.
6 changes: 3 additions & 3 deletions src/pip/_internal/resolution/resolvelib/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ def get_preference(
else:
candidate, ireqs = None, ()

operators = [
specifier.operator
operators: list[tuple[str, str]] = [
(specifier.operator, specifier.version)
for specifier_set in (ireq.specifier for ireq in ireqs if ireq)
for specifier in specifier_set
]

direct = candidate is not None
pinned = any(op[:2] == "==" for op in operators)
pinned = any(((op[:2] == "==") and ("*" not in ver)) for op, ver in operators)
unfree = bool(operators)
requested_order = self._user_requested.get(identifier, math.inf)

Expand Down
8 changes: 8 additions & 0 deletions tests/unit/resolution_resolvelib/test_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ def build_req_info(
{},
(True, False, False, True, math.inf, False, "pinned-package"),
),
# Star-specified package, i.e. with "*"
(
"star-specified-package",
{"star-specified-package": [build_req_info("star-specified-package==1.*")]},
[],
{},
(True, False, True, True, math.inf, False, "star-specified-package"),
),
# Package that caused backtracking
(
"backtrack-package",
Expand Down