Fix invalid origin test to check all the logged messages #12875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
approved these changes
Jul 26, 2024
Member
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
Looks fine. I'm not entirely sure why this is failing intermittently since the logs should be isolated from each other, but /shrug. We could also do caplog.set_level(logging.WARNING) to filter out the irrelevant debug logs, but it's not necessary.
pradyunsg
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12152
Pretty simple fix, the log also contains stuff from other tests, so when everything is ran together, the first message is not what we expect. It works as expected if we run it solo.