Move type checking outside pre-commit #12866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke mypy with specific directories rather than a list of files found by pre-commit in the repository. This makes it catch more errors and issues.
|
@pradyunsg are you still interested in completing this? The frozen additional-dependencies for pre-commit I find really easy to forget, I would like to move them into a dependency group, which would mean pulling mypy out of pre-commit as pre-commit has no other way to support dependencies. I would be willing to pick this up. |
|
I don't think I'll have the time to wrap this up in the near future -- please feel welcome to pick this up and drive it forward. |
|
Superseded by @notatallshaw's PR #13476. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/mypy#13916 and https://jaredkhan.com/blog/mypy-pre-commit
I'm basically taking the approach of "Running Mypy correctly outside of Pre-commit" (from the second link) and stopping there since I don't think we gain a lot by shoving mypy into pre-commit.
Keeping this as a draft to showcase all the new errors that mypy is now capable of flagging.