Skip to content

Stop explicitly listing wheel as a build dependency #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Stop explicitly listing wheel as a build dependency #12728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3c51d
Stop explicitly listing wheel as a build dependency
hroncok May 24, 2024
c547edf
Fix typo in news fragment
uranusjr May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions news/12728.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
``wheel`` is no longer explicitly listed as a build depepndency of ``pip``.
``setuptools`` already injects this dependency in the ``get_requires_for_build_wheel()`` hook.
This makes no difference for users of ``pip``.
This makes no difference when building wheels of ``pip``.
This avoids an unnecessary dependency on ``wheel`` when building the source distribution of ``pip``.
Copy link
Member

@sbidoul sbidoul Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a user facing feature, I'd rename this news/12728.process.rst which is the best category we have now for this kind of change to the build process

Copy link
Member

@webknjaz webknjaz Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue that it's a bugfix. But a "process"? This is a rather weird workaround.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Changelog = "https://pip.pypa.io/en/stable/news/"

[build-system]
# The lower bound is for <https://github.com/pypa/setuptools/issues/3865>.
requires = ["setuptools>=67.6.1", "wheel"]
requires = ["setuptools>=67.6.1"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
Expand Down