Improve protected_pip.py by adding additional context
#11196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
skip news
This additional context provided by the various comments within the lightly-refactored implementation should make it easier to understand what this file is for, how it works and when it is useful.
This is a core piece in our testing bootstrap, so modifications to it should trigger tests on CI.
pradyunsg
force-pushed
the
improve-protected-pip
branch
from
e8c4ff9 to
da2ab17
Compare
|
OK, this should now get CI tests. Assuming those pass, as a heads up, I'll probably merge this without reviews. This is a repeat of an already-approved PR with one minor change to fix a bug that we missed. |
|
And, CI does not pass because of build isolation. Once #11257 is merged, that'll get fixed. |
|
Actually, nvm. This is mostly a cleanup, and it's not a big deal if we don't do this. If someone else wants to pick this up, please feel welcome to! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional context provided by the various comments within the
lightly-refactored implementation should make it easier to understand
what this file is for, how it works and when it is useful.
Follow up to #11078