Make proper annotations in noxfile.py
#10047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I said on the pypa PR 10018, it is necessary to convert the commentaries into proper annotations.
DiddiLeija
changed the title
noxfile.pynoxfile.py
This is the respective news entry for this pull request.
Member
Author
|
I think we can merge, but I can't do it by myself. If any member wants to merge, feel free of doing it. |
uranusjr
approved these changes
Jun 8, 2021
Member
Author
|
Hi @uranusjr . As I can't merge here, could you please merge this pull request? |
Member
|
Thanks @DiddiLeija! ^>^ |
Member
Author
|
Thanks to you, @pradyunsg for merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I proposed on the PR #10018 and #10004, it is necessary to convert the type commentaries into proper annotations. For this pull request, I only attempted to annotate in
noxfile.py.