Pip install local with extra fails dependency resolution

[KochankovID]

Description

Let's say we have a package that we install locally via pip (the version name is generated something like 0.20.0.dev48+g4d91197). Then we install the same package locally, but with the indication extra. Pip in this case refuses to install the package due to an error: could not find a version that satisfies the requirement

Expected behavior

For example, take the gitlint repository: https://github.com/jorisroovers/gitlint

If you use it as a pre-commit, the following will happen: pip install . ./gitlint-core[trusted-deps]

When installing gitlint itself (pip install .) gitlint-core is being installed. Then the installation of gitlint-core[trusted-deps] (pip install ./gitlint-core[trusted-deps]) starts and fails.

pip-23.2.1 - works as needed
pip-23.3.1 - error

pip version

23.3.1

Python version

Python 3.11.0

OS

mac os m1

How to Reproduce

1. git clone https://github.com/jorisroovers/gitlint.git
2. cd gitlint
3. pip install . ./gitlint-core[trusted-deps]

Output

Processing /Users/ilyakochankov/Yandex.Disk.localized/Programming/gitlint
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Processing ./gitlint-core
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
INFO: pip is looking at multiple versions of gitlint to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement gitlint-core==0.20.0.dev48+g4d91197 (from gitlint) (from versions: 0.17.0, 0.18.0, 0.19.0.dev73, 0.19.0.dev75, 0.19.0.dev76, 0.19.0.dev77, 0.19.0.dev78, 0.19.0.dev79, 0.19.0.dev80, 0.19.0.dev81, 0.19.0.dev82, 0.19.0rc1, 0.19.0rc2.dev1, 0.19.0rc2, 0.19.0rc3.dev1, 0.19.0, 0.19.1.dev1, 0.19.1.dev2, 0.19.1, 0.19.2.dev1, 0.19.2.dev2, 0.19.2.dev3, 0.19.2.dev4, 0.19.2.dev5, 0.20.0.dev2, 0.20.0.dev3, 0.20.0.dev6, 0.20.0.dev7, 0.20.0.dev8, 0.20.0.dev9, 0.20.0.dev10, 0.20.0.dev11, 0.20.0.dev12, 0.20.0.dev13, 0.20.0.dev14, 0.20.0.dev15, 0.20.0.dev16, 0.20.0.dev17, 0.20.0.dev18, 0.20.0.dev19, 0.20.0.dev20, 0.20.0.dev21, 0.20.0.dev22, 0.20.0.dev23, 0.20.0.dev24, 0.20.0.dev25, 0.20.0.dev27, 0.20.0.dev29, 0.20.0.dev30, 0.20.0.dev31, 0.20.0.dev32, 0.20.0.dev33, 0.20.0.dev34, 0.20.0.dev35, 0.20.0.dev36, 0.20.0.dev37, 0.20.0.dev38, 0.20.0.dev39, 0.20.0.dev40, 0.20.0.dev41, 0.20.0.dev42, 0.20.0.dev43, 0.20.0.dev44, 0.20.0.dev45, 0.20.0.dev48)
ERROR: No matching distribution found for gitlint-core==0.20.0.dev48+g4d91197

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[KochankovID]

jorisroovers/gitlint#535

[edmorley]

@uranusjr @sanderr This seems like it could this be a pip 23.3 regression from either #12002 or #12095?

[sbidoul]

Tentatively added to the 23.3 milestone.

[sanderr]

Seems to be a regression in #12095 (reproduced issue on merge commit b551c09, while its parent dfaac0a doesn't suffer from it). I don't immediately see how yet but I'll have a more in-depth look.

[sanderr]

I have a PoC level fix available here. I haven't considered all consequences yet and it needs some cleaning up, but could you already give it a shot and see if it resolves your issue?

You might also be interested to know that it seems to work fine if you swap the order of the install specifiers, i.e. pip download ./gitlint-core/[trusted-deps] .

EDIT: cleaned it up, just need to add a test case and verify that it didn't break anything.

[edmorley]

@KochankovID Have you had a chance to try out @sanderr's proposed fix?

To install that branch, run:
pip install https://github.com/sanderr/pip/archive/refs/heads/issue/12373-bugfix-install-local-extra.zip

[KochankovID]

@edmorley I tried - fixed it! 🔥

Processing /Users/ilyakochankov/gitlint
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Processing ./gitlint-core
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: arrow>=1 in /Users/ilyakochankov/.pyenv/versions/3.11.0/lib/python3.11/site-packages (from gitlint-core==0.20.0.dev48+g4d91197) (1.2.3)
Requirement already satisfied: click>=8 in /Users/ilyakochankov/.pyenv/versions/3.11.0/lib/python3.11/site-packages (from gitlint-core==0.20.0.dev48+g4d91197) (8.1.7)
Requirement already satisfied: python-dateutil>=2.7.0 in /Users/ilyakochankov/.pyenv/versions/3.11.0/lib/python3.11/site-packages (from arrow>=1->gitlint-core==0.20.0.dev48+g4d91197) (2.8.2)
Requirement already satisfied: six>=1.5 in /Users/ilyakochankov/.pyenv/versions/3.11.0/lib/python3.11/site-packages (from python-dateutil>=2.7.0->arrow>=1->gitlint-core==0.20.0.dev48+g4d91197) (1.16.0)
Building wheels for collected packages: gitlint, gitlint-core
Building wheel for gitlint (pyproject.toml) ... done
Created wheel for gitlint: filename=gitlint-0.20.0.dev48+g4d91197-py3-none-any.whl size=2882 sha256=7711f00a4d7746e76609f581fe7543a2049e6f3ced2a5eeb22135b0a69785a9d
Stored in directory: /private/var/folders/tl/2sfc4zys07sfhnn129zy0l4c0000gn/T/pip-ephem-wheel-cache-5pbuliek/wheels/b9/ec/06/afe4f2473f03366d2fe7654a91eeaf889fde03c8fab404d8c5
Building wheel for gitlint-core (pyproject.toml) ... done
Created wheel for gitlint-core: filename=gitlint_core-0.20.0.dev48+g4d91197-py3-none-any.whl size=44605 sha256=81c8c224d47424413e0a05727e32f141e5fcf352978dccc67f78cc6e4083b038
Stored in directory: /Users/ilyakochankov/Library/Caches/pip/wheels/4b/2f/d8/7cb0cb4eb04680eaaaaae9ace7367afc3dee4c88d5f64dd397
Successfully built gitlint gitlint-core
Installing collected packages: gitlint-core, gitlint
Successfully installed gitlint-0.20.0.dev48+g4d91197 gitlint-core-0.20.0.dev48+g4d91197