Remove a few more obsolete pep517 things from the test suite

Author: sbidoul

tests/functional/test_download.py

@@ -17,7 +17,6 @@
     ScriptFactory,
     TestData,
     TestPipResult,
-    create_basic_sdist_for_package,
     create_really_basic_wheel,
 )
 from tests.lib.server import MockServer, file_response
@@ -1228,49 +1227,6 @@ def test_download_editable(
     assert downloads[0].endswith(".zip")
 
 
-def test_download_use_pep517_propagation(
-    script: PipTestEnvironment, tmpdir: Path, common_wheels: Path
-) -> None:
-    """
-    Check that --use-pep517 applies not just to the requirements specified
-    on the command line, but to their dependencies too.
-    """
-
-    create_basic_sdist_for_package(script, "fake_proj", "1.0", depends=["fake_dep"])
-
-    # If --use-pep517 is in effect, then setup.py should be running in an isolated
-    # environment that doesn't have pip in it.
-    create_basic_sdist_for_package(
-        script,
-        "fake_dep",
-        "1.0",
-        setup_py_prelude=textwrap.dedent(
-            """\
-            try:
-                import pip
-            except ImportError:
-                pass
-            else:
-                raise Exception(f"not running in isolation")
-            """
-        ),
-    )
-
-    download_dir = tmpdir / "download_dir"
-    script.pip(
-        "download",
-        f"--dest={download_dir}",
-        "--no-index",
-        f"--find-links={common_wheels}",
-        f"--find-links={script.scratch_path}",
-        "--use-pep517",
-        "fake_proj",
-    )
-
-    downloads = os.listdir(download_dir)
-    assert len(downloads) == 2
-
-
 @pytest.fixture
 def download_local_html_index(
     script: PipTestEnvironment,

tests/functional/test_install.py

@@ -804,12 +804,12 @@ def test_hashed_install_from_cache(
         tmpdir,
     ) as reqs_file:
         result = script.pip_install_local(
-            "--use-pep517", "--no-build-isolation", "-r", reqs_file.resolve()
+            "--no-build-isolation", "-r", reqs_file.resolve()
         )
         assert "Created wheel for simple2" in result.stdout
         script.pip("uninstall", "simple2", "-y")
         result = script.pip_install_local(
-            "--use-pep517", "--no-build-isolation", "-r", reqs_file.resolve()
+            "--no-build-isolation", "-r", reqs_file.resolve()
         )
         assert "Using cached simple2" in result.stdout
     # now try with an invalid hash
@@ -819,7 +819,6 @@ def test_hashed_install_from_cache(
     ) as reqs_file:
         script.pip("uninstall", "simple2", "-y")
         result = script.pip_install_local(
-            "--use-pep517",
             "--no-build-isolation",
             "-r",
             reqs_file.resolve(),

tests/functional/test_install_index.py

@@ -28,7 +28,6 @@ def test_find_links_no_doctype(script: PipTestEnvironment, data: TestData) -> No
     result = script.pip(
         "install",
         "simple==1.0",
-        "--use-pep517",
         "--no-build-isolation",
         "--no-index",
         "--find-links",

tests/unit/test_pep517.py

@@ -4,27 +4,9 @@
 
 import pytest
 
-from pip._internal.exceptions import InstallationError, InvalidPyProjectBuildRequires
+from pip._internal.exceptions import InvalidPyProjectBuildRequires
 from pip._internal.req import InstallRequirement
 
-from tests.lib import TestData
-
-
-def test_use_pep517_rejects_setup_cfg_only(shared_data: TestData) -> None:
-    """
-    Test that projects with setup.cfg but no pyproject.toml are rejected.
-    """
-    src = shared_data.src.joinpath("pep517_setup_cfg_only")
-    req = InstallRequirement(None, None)
-    req.source_dir = os.fspath(src)  # make req believe it has been unpacked
-    with pytest.raises(InstallationError) as e:
-        req.load_pyproject_toml()
-    err_msg = e.value.args[0]
-    assert (
-        "does not appear to be a Python project: "
-        "neither 'setup.py' nor 'pyproject.toml' found" in err_msg
-    )
-
 
 @pytest.mark.parametrize(
     "spec", [("./foo",), ("git+https://example.com/pkg@dev#egg=myproj",)]

tests/unit/test_wheel_builder.py

@@ -41,15 +41,13 @@ class ReqMock:
     link: Link | None = None
     constraint: bool = False
     source_dir: str | None = "/tmp/pip-install-123/pendulum"
-    use_pep517: bool = True
     supports_pyproject_editable: bool = False
 
 
 @pytest.mark.parametrize(
     "req, expected",
     [
-        (ReqMock(editable=True, use_pep517=False), False),
-        (ReqMock(editable=True, use_pep517=True), False),
+        (ReqMock(editable=True), False),
         (ReqMock(source_dir=None), False),
         (ReqMock(link=Link("git+https://g.c/org/repo")), False),
         (ReqMock(link=Link("https://g.c/dist.tgz")), False),