Fix and expand PEP 660 detection

Since there is no 'setup.py develop' fallback anymore,
this check needs to be updated, and also needs to run
when not using build isolation.

Author: sbidoul

src/pip/_internal/distributions/sdist.py

@@ -46,16 +46,17 @@ def prepare_distribution_metadata(
             # Setup an isolated environment and install the build backend static
             # requirements in it.
             self._prepare_build_backend(build_env_installer)
-            # Check that if the requirement is editable, it either supports PEP 660 or
-            # has a setup.py or a setup.cfg. This cannot be done earlier because we need
-            # to setup the build backend to verify it supports build_editable, nor can
-            # it be done later, because we want to avoid installing build requirements
-            # needlessly. Doing it here also works around setuptools generating
-            # UNKNOWN.egg-info when running get_requires_for_build_wheel on a directory
-            # without setup.py nor setup.cfg.
-            self.req.isolated_editable_sanity_check()
+            # Check that the build backend supports PEP 660. This cannot be done
+            # earlier because we need to setup the build backend to verify it
+            # supports build_editable, nor can it be done later, because we want
+            # to avoid installing build requirements needlessly.
+            self.req.editable_sanity_check()
             # Install the dynamic build requirements.
             self._install_build_reqs(build_env_installer)
+        else:
+            # When not using build isolation, we still need to check that
+            # the build backend supports PEP 660.
+            self.req.editable_sanity_check()
         # Check if the current environment provides build dependencies
         if check_build_deps:
             pyproject_requires = self.req.pyproject_requires

src/pip/_internal/req/req_install.py

@@ -464,13 +464,6 @@ def setup_py_path(self) -> str:
 
         return setup_py
 
-    @property
-    def setup_cfg_path(self) -> str:
-        assert self.source_dir, f"No source dir for {self}"
-        setup_cfg = os.path.join(self.unpacked_source_directory, "setup.cfg")
-
-        return setup_cfg
-
     @property
     def pyproject_toml_path(self) -> str:
         assert self.source_dir, f"No source dir for {self}"
@@ -496,21 +489,15 @@ def load_pyproject_toml(self) -> None:
             backend_path=backend_path,
         )
 
-    def isolated_editable_sanity_check(self) -> None:
+    def editable_sanity_check(self) -> None:
         """Check that an editable requirement if valid for use with PEP 517/518.
 
-        This verifies that an editable that has a pyproject.toml either supports PEP 660
-        or as a setup.py or a setup.cfg
+        This verifies that an editable has a build backend that supports PEP 660.
         """
-        if (
-            self.editable
-            and not self.supports_pyproject_editable
-            and not os.path.isfile(self.setup_py_path)
-            and not os.path.isfile(self.setup_cfg_path)
-        ):
+        if self.editable and not self.supports_pyproject_editable:
             raise InstallationError(
-                f"Project {self} has a 'pyproject.toml' and its build "
-                f"backend is missing the 'build_editable' hook, so "
+                f"Project {self} uses a build backend "
+                f"that is missing the 'build_editable' hook, so "
                 f"it cannot be installed in editable mode. "
                 f"Consider using a build backend that supports PEP 660."
             )

tests/functional/test_pep660.py

@@ -2,6 +2,7 @@
 from pathlib import Path
 from typing import Any
 
+import pytest
 import tomli_w
 
 from tests.lib import PipTestEnvironment
@@ -164,27 +165,31 @@ def test_install_pep660_from_reqs_file(
     ), "a .egg-link file should not have been created"
 
 
-def test_install_no_pep660(tmpdir: Path, script: PipTestEnvironment) -> None:
+@pytest.mark.parametrize("isolation_arg", [[], ["--no-build-isolation"]])
+def test_install_no_pep660(
+    isolation_arg: list[str],
+    tmpdir: Path,
+    script: PipTestEnvironment,
+    common_wheels: Path,
+) -> None:
     """
     Test the error message when the build backend does not support PEP 660.
-    Since there is a pyproject.toml, the prepare_metadata_for_build_wheel hook
-    is called.
+
+    The error is the same with and without build isolation.
     """
     project_dir = _make_project(tmpdir, BACKEND_WITHOUT_PEP660, with_setup_py=True)
     result = script.pip(
         "install",
         "--no-index",
-        "--no-build-isolation",
+        "-f",
+        common_wheels,
+        *isolation_arg,
         "--editable",
         project_dir,
         allow_error=True,
     )
     assert result.returncode != 0
-    _assert_hook_called(project_dir, "prepare_metadata_for_build_wheel")
-    assert (
-        "Cannot build editable project because "
-        "the build backend does not have the build_editable hook" in result.stderr
-    )
+    assert "missing the 'build_editable' hook" in result.stderr
 
 
 def test_wheel_editable_pep660_basic(tmpdir: Path, script: PipTestEnvironment) -> None: