Skip to content

Change slave to device_id and slave= to device_id=. #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

janiversen
Copy link
Collaborator

No description provided.

@janiversen janiversen merged commit 2f87de9 into dev Mar 6, 2025
1 check passed
@janiversen janiversen deleted the slave branch March 6, 2025 18:09
@hyrodium
Copy link

This is a breaking change. I think the latest release should be v4.0.0, not v3.10.0.

@janiversen
Copy link
Collaborator Author

Did you read the README, pymodbus does minor API. changes in x.y releases.

It is clearly documented what releases can contain ! you might like to have another way of doing it, but we have quite a lot of reasons for not doing semver.

v3.10 contains changes which you can solve with a simple edit. v4.0.0 will require a rewrite of parts of your program.

@hyrodium
Copy link

Oh, I am sorry that I have overlooked the README. I mistakenly thought it was semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants