Skip to content

Improve server types #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Improve server types #2092

merged 2 commits into from
Mar 7, 2024

Conversation

alexrudd2
Copy link
Collaborator

tuple -> list (easy)

For the other commit, see discussion in #2033

A refactor is the best choice for _serverList, so just ignore it for now.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 636443f into dev Mar 7, 2024
@janiversen janiversen deleted the server-types branch March 7, 2024 18:03
janiversen pushed a commit to dnssoftware/pymodbus that referenced this pull request Mar 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants