Skip to content

Test and correct receiving more than one packet #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 4, 2024
Merged

Test and correct receiving more than one packet #1965

merged 12 commits into from
Feb 4, 2024

Conversation

janiversen
Copy link
Collaborator

@janiversen janiversen commented Feb 4, 2024

fixes #1949

First a new test case is made to show the problem.

There was a problem in advanceFrame, but with this PR we actually silently support multiple parallel calls in async mode.

the suggestion for a change in getFrame, was not correct, it does not work for exception respons

@janiversen janiversen marked this pull request as draft February 4, 2024 08:44
@janiversen janiversen marked this pull request as ready for review February 4, 2024 14:34
@janiversen janiversen merged commit 9b67640 into dev Feb 4, 2024
@janiversen janiversen deleted the solve_1949 branch February 4, 2024 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModbusSocketFramer bug when multiple modbus messages are received in 1 tcp payload
1 participant