Skip to content

Fix rtd builds #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix rtd builds #164

merged 1 commit into from
Jan 23, 2023

Conversation

OriolAbril
Copy link
Contributor

@OriolAbril OriolAbril commented Jan 20, 2023 •
edited
Loading

I noticed docs weren't being build from main. This updates the readthedocs config so it takes into account pyproject and extra pip installs with [] are used now instead of requirements files. closes #158

drbenvincent
drbenvincent approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. I initially missed this getting broken when moving over to pyproject.toml, so fixing this was on my list. So this is great.

@drbenvincent drbenvincent merged commit 10cd742 into pymc-labs:main Jan 23, 2023
@OriolAbril OriolAbril deleted the patch-1 branch January 23, 2023 19:09
@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drbenvincent drbenvincent drbenvincent approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remote build of docs is broken

2 participants

@OriolAbril @drbenvincent