Skip to content

Extend cholesky of triangular dot rewrite to matmul Ops #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2023
Merged

Extend cholesky of triangular dot rewrite to matmul Ops #459

merged 2 commits into from
Sep 28, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Sep 26, 2023 •
edited
Loading

Also restrict to 2D Dot cases

Also reverts #455

@ricardoV94 ricardoV94 added bug Something isn't working enhancement New feature or request graph rewriting linalg Linear algebra labels Sep 26, 2023
@ricardoV94 ricardoV94 force-pushed the tweak_chol_dot_rewrite branch from 5d7e3cb to c996ce1 Compare September 26, 2023 12:06
jessegrabowski
jessegrabowski reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending that you check the typo on ndim in the unittest

@ricardoV94 ricardoV94 force-pushed the tweak_chol_dot_rewrite branch from c996ce1 to c06fdb0 Compare September 27, 2023 15:58
@ricardoV94 ricardoV94 marked this pull request as ready for review September 27, 2023 15:59
@ricardoV94 ricardoV94 mentioned this pull request Sep 27, 2023
Merged
jessegrabowski
jessegrabowski approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit 39aa123 into pymc-devs:main Sep 28, 2023
@ricardoV94 ricardoV94 deleted the tweak_chol_dot_rewrite branch September 28, 2023 10:38
@jessegrabowski jessegrabowski mentioned this pull request Jan 5, 2024
Open
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessegrabowski jessegrabowski jessegrabowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request graph rewriting linalg Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoV94 @jessegrabowski