Skip to content

Fix flaky CI tests #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+6 −4
Merged

Fix flaky CI tests #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9d495
Force environment dependent xfail test to fail
ricardoV94 Nov 18, 2025
97101c4
New version of MLX crashing in CI
ricardoV94 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
if [[ $INSTALL_NUMBA == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" "numba>=0.57"; fi
if [[ $INSTALL_JAX == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" jax jaxlib numpyro equinox && pip install tfp-nightly; fi
if [[ $INSTALL_TORCH == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" pytorch pytorch-cuda=12.1 "mkl<=2024.0" -c pytorch -c nvidia; fi
if [[ $INSTALL_MLX == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" mlx; fi
if [[ $INSTALL_MLX == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" "mlx<0.29.4"; fi
if [[ $INSTALL_XARRAY == "1" ]]; then micromamba install --yes -q -c conda-forge "python~=${PYTHON_VERSION}" xarray xarray-einstats; fi

pip install -e ./
Expand Down
8 changes: 5 additions & 3 deletions tests/tensor/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,9 +1411,7 @@ def _grad_list(self):
"uint32",
pytest.param(
"uint64",
marks=pytest.mark.xfail(
condition=config.mode != "FAST_COMPILE", reason="Fails due to #770"
),
marks=pytest.mark.xfail(reason="Fails due to #770"),
),
),
)
Expand All @@ -1433,6 +1431,10 @@ def test_uint(self, dtype):
assert max_out.dtype == dtype
i_max = function([n], max_out)(data)
assert i_max == itype.max
if dtype == "uint64":
assert (
0
) # It's not failing in all the CIs but we have XPASS(strict) enabled

@pytest.mark.xfail(
condition=config.mode != "FAST_COMPILE", reason="Fails due to #770"
Expand Down
Loading