Skip to content

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Sep 17, 2024

Description

This PR adds grep-based hooks that notably check for the use of double backticks for code in rst files, and that all noqa and type ignore statements are qualified.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7507.org.readthedocs.build/en/7507/

@Armavica Armavica added pre-commit no releasenotes Skipped in automatic release notes generation labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (1b6d7db) to head (1fb1aff).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
pymc/backends/__init__.py 0.00% 2 Missing ⚠️
pymc/math.py 0.00% 1 Missing ⚠️
pymc/sampling/parallel.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7507      +/-   ##
==========================================
+ Coverage   89.98%   92.69%   +2.70%     
==========================================
  Files         104      104              
  Lines       17412    17408       -4     
==========================================
+ Hits        15669    16137     +468     
+ Misses       1743     1271     -472     
Files with missing lines Coverage Δ
pymc/distributions/shape_utils.py 90.90% <100.00%> (ø)
pymc/distributions/simulator.py 84.28% <100.00%> (ø)
pymc/distributions/transforms.py 98.47% <100.00%> (ø)
pymc/gp/cov.py 98.66% <100.00%> (ø)
pymc/gp/hsgp_approx.py 88.39% <100.00%> (+70.16%) ⬆️
pymc/logprob/basic.py 94.28% <100.00%> (ø)
pymc/logprob/tensor.py 100.00% <100.00%> (ø)
pymc/model/transform/optimization.py 100.00% <100.00%> (+2.43%) ⬆️
pymc/model_graph.py 87.25% <100.00%> (+17.37%) ⬆️
pymc/sampling/forward.py 96.15% <100.00%> (ø)
... and 11 more

... and 8 files with indirect coverage changes

@ricardoV94
Copy link
Member

The failing tests don't seem a fluke. But not related to this PR either?

@Armavica
Copy link
Member Author

Armavica commented Oct 8, 2024

No, they are failing on main too.

@ricardoV94
Copy link
Member

No, they are failing on main too.

Opened PR to fix it: #7529

@Armavica Armavica merged commit 1457626 into pymc-devs:main Oct 8, 2024
22 checks passed
@Armavica Armavica deleted the pygrep-hooks branch October 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs no releasenotes Skipped in automatic release notes generation pre-commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants