Skip to content

Conversation

@gokuld
Copy link
Contributor

@gokuld gokuld commented Mar 23, 2023

What is this PR about?
Adding ICDF functions for the existing discrete uniform distribution.
Issue: 6612
Creation of tests for added ICDF functions.

Checklist

Major / Breaking Changes

  • ...

New features

  • ICDF function for the discrete uniform distribution.

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Extended test_discrete.py with corresponding tests.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #6617 (bead510) into main (067d89b) will decrease coverage by 4.92%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6617      +/-   ##
==========================================
- Coverage   92.01%   87.10%   -4.92%     
==========================================
  Files          93       93              
  Lines       15742    15746       +4     
==========================================
- Hits        14485    13715     -770     
- Misses       1257     2031     +774     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 98.73% <100.00%> (+0.01%) ⬆️

... and 16 files with indirect coverage changes

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ricardoV94
Copy link
Member

Thanks @gokuld!

@ricardoV94 ricardoV94 merged commit 2fcce43 into pymc-devs:main Mar 24, 2023
@gokuld
Copy link
Contributor Author

gokuld commented Mar 24, 2023

@ricardoV94 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants