Skip to content

Conversation

@ferrine
Copy link
Member

@ferrine ferrine commented Sep 7, 2022

Without __init__.py this module is not installed in pymc-experimental and test builds are broken.

What is this PR about?
...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

Without `__init__.py` this module is not installed in pymc-experimental and test builds are broken.
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #6104 (19b8dde) into main (23df308) will increase coverage by 2.51%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6104      +/-   ##
==========================================
+ Coverage   89.56%   92.07%   +2.51%     
==========================================
  Files          72       86      +14     
  Lines       12927    17861    +4934     
==========================================
+ Hits        11578    16446    +4868     
- Misses       1349     1415      +66     
Impacted Files Coverage Δ
pymc/distributions/__init__.py 100.00% <ø> (ø)
pymc/sampling.py 82.13% <ø> (-0.02%) ⬇️
pymc/tests/distributions/test_dist_math.py 99.25% <ø> (ø)
pymc/tests/distributions/test_timeseries.py 93.75% <90.00%> (ø)
pymc/tests/distributions/util.py 90.86% <90.86%> (ø)
pymc/printing.py 86.08% <92.59%> (-0.58%) ⬇️
pymc/distributions/timeseries.py 78.52% <94.25%> (+0.53%) ⬆️
pymc/distributions/logprob.py 97.31% <94.73%> (-0.42%) ⬇️
pymc/aesaraf.py 92.91% <96.00%> (+0.71%) ⬆️
pymc/distributions/multivariate.py 92.31% <96.20%> (+0.07%) ⬆️
... and 29 more

@ricardoV94
Copy link
Member

CC @Armavica, we should keep this in mind in future PRs

@ricardoV94 ricardoV94 merged commit 761f77d into main Sep 7, 2022
@ricardoV94 ricardoV94 deleted the fix-missing-test-module branch November 2, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants