Infer dims & coords from xarray variables passed to pm.Data #5796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaelosthege
left a comment
michaelosthege
left a comment
There was a problem hiding this comment.
sorry @mjhajharia, I forgot to submit the review commend I made a few days ago 🙈
It looks like there's a block of code that got duplicated?
| if dim_name is not None: | ||
| coords[dim_name] = value.index | ||
| if dims is None: | ||
| dims = dims_name |
Member
There was a problem hiding this comment.
dims should be a list
In addition, it might be a good idea to account for the case of Multi-Indexed DataFrames. (raise?)
Member
|
Is this PR salvageable or should we close it? |
Member
|
Actually this was continued & completed in #6514, so we can close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #5791
cc: @michaelosthege (I might have made errors, also I just emulated the pandas code for xarray, not sure if it makes sense)