add categorical moment #5176
Merged
add categorical moment #5176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5176 +/- ##
==========================================
- Coverage 78.09% 78.08% -0.02%
==========================================
Files 88 88
Lines 14149 14166 +17
==========================================
+ Hits 11050 11061 +11
- Misses 3099 3105 +6
|
51 tasks
ricardoV94
reviewed
Nov 13, 2021
| @pytest.mark.parametrize( | ||
| "p, size, expected", | ||
| [ | ||
| (np.arange(0.1, 0.4, 0.1), None, 3), |
Member
There was a problem hiding this comment.
Looks good but can we perhaps have some of the tests have the moment not be the last element?
Also for readability defining the p explicitly such as np.array([.6, .1, .3]) seems better.
Contributor
Author
There was a problem hiding this comment.
Ah sure, I agree it is not really readable.
ricardoV94
approved these changes
Nov 13, 2021
Member
|
Looks good, just checking if the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add moments and tests for the below distributions as part of #5078: