Condition xfails on Windows after bug fix affected linux only #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for Aesara issue 390 was rolled out with Aesara 2.1.3 but apparently it did not fix the problem on Windows.
Codecov Report
@@ Coverage Diff @@
## main #4902 +/- ##
===========================================
+ Coverage 62.39% 73.16% +10.77%
===========================================
Files 86 86
Lines 13838 13838
===========================================
+ Hits 8634 10125 +1491
+ Misses 5204 3713 -1491
|
canyon289
approved these changes
Aug 4, 2021
Member
|
Sorry closed by accident. Reopened |
ricardoV94
approved these changes
Aug 5, 2021
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
Do we have an open issue to track this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for aesara-devs/aesara#390 was rolled out with Aesara 2.1.3 but apparently it did not fix the problem on Windows.
The pipeline on
mainstarted failing right after the release, while the commits on PyMC3mainwere just typo fixes:Unfortunately I don't have much time to spare, so this PR just limits the scope of the XFAIL marks to make the CI pass again.
CC @brandonwillard in case you have an idea while the issue may still persist.