Skip to content

Conversation

@michaelosthege
Copy link
Member

The latest Aesara release caused a test to break.

The latest CI run on main was with Aesara 2.1.0, but I ran into this problem while working on #4867.

Since I don't have the leisure to diagnose/fix, this PR pins the Aesara version.
If someone wants to fix it, feel free to push this branch!
Otherwise I think we should merge ASAP to prevent other PRs from stalling on unrelated CI failures.

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #4868 (32dd28f) into main (25da9e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4868   +/-   ##
=======================================
  Coverage   72.82%   72.82%           
=======================================
  Files          86       86           
  Lines       13795    13795           
=======================================
  Hits        10046    10046           
  Misses       3749     3749           

@brandonwillard
Copy link
Contributor

The latest CI run on main was with Aesara 2.1.0, but I ran into this problem while working on #4867.

Since I don't have the leisure to diagnose/fix, this PR pins the Aesara version.
If someone wants to fix it, feel free to push this branch!
Otherwise I think we should merge ASAP to prevent other PRs from stalling on unrelated CI failures.

Please clearly identify the problem before asking others to merge something ASAP.

First, is there a specific test that's failing in a way that's identifiably related to changes in Aesara? Can you at least link to one of the failures in #4867 that you think is relevant?

Right now you're asking others to sift through your PR's CI output, yet you've likely done this yourself in order to confirm that your changes aren't the cause of the/some failures, no?

@brandonwillard
Copy link
Contributor

Superseded by #4869.

@michaelosthege michaelosthege deleted the pin-aesara-2-1-0 branch August 7, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants