Skip to content

Conversation

@ricardoV94
Copy link
Member

CI tests for logcdf methods that make use of dist_math.incomplete_beta::incomplete_beta are crazy slow. This is reported in #4420

This PR simply reduces the number of random tested points, which could save up to an hour in the CIs. Note that a similar change was already done for the logcdf method of the StudentT in #3823 for the same reasons.

Besides, these methods have passed many times now without failures, so it should be okay to reduce the number of points in each run. Objections?

Depending on what your PR does, here are a few things you might want to address in the description:

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@ricardoV94 ricardoV94 merged commit 60e0dae into pymc-devs:master Feb 3, 2021
@ricardoV94 ricardoV94 deleted the reduce_long_distribution_tests branch February 18, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants