Fix number of tune steps with cores>1 #3821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3821 +/- ##
==========================================
- Coverage 90.78% 90.77% -0.02%
==========================================
Files 133 133
Lines 20560 20566 +6
==========================================
+ Hits 18665 18668 +3
- Misses 1895 1898 +3
|
michaelosthege
changed the title
Member
|
👍 |
sthagen
added a commit
to sthagen/pymc-devs-pymc
that referenced
this pull request
Mar 3, 2020
Fix number of tune steps with cores>1 (pymc-devs#3821)
michaelosthege
added a commit
to michaelosthege/pymc
that referenced
this pull request
Feb 25, 2023
Removes a regression test added in pymc-devs#3821 because it took 14 seconds.
michaelosthege
added a commit
that referenced
this pull request
Feb 26, 2023
* Extract return part of `pm.sample` * Speed up `test_mcmc` * Group tests related to `pm.sample` return parameters * Consolidate tests of return options Removes a regression test added in #3821 because it took 14 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main iterator in multiprocess sampling took draws before checking the
draw == self._tunecondition. As a result,sample(cores>1)always took one tune draw more than it should have.