Deprecate pytensor_config

Author: ricardoV94

pymc/model/core.py

@@ -496,7 +496,13 @@ def __new__(cls, *args, **kwargs):
             instance._parent = kwargs.get("model")
         else:
             instance._parent = cls.get_context(error_if_none=False)
-        instance._pytensor_config = kwargs.get("pytensor_config", {})
+        pytensor_config = kwargs.get("pytensor_config", {})
+        if pytensor_config:
+            warnings.warn(
+                "pytensor_config is deprecated. Use pytensor.config or pytensor.config.change_flags context manager instead.",
+                FutureWarning,
+            )
+        instance._pytensor_config = pytensor_config
         return instance
 
     @staticmethod

tests/model/test_core.py

@@ -1102,7 +1102,9 @@ def test_compile_fn():
 
 def test_model_pytensor_config():
     assert pytensor.config.mode != "JAX"
-    with pm.Model(pytensor_config=dict(mode="JAX")) as model:
+    with pytest.warns(FutureWarning, match="pytensor_config is deprecated"):
+        m = pm.Model(pytensor_config=dict(mode="JAX"))
+    with m:
         assert pytensor.config.mode == "JAX"
     assert pytensor.config.mode != "JAX"
 

tests/sampling/test_mcmc.py

@@ -797,14 +797,6 @@ def test_step_vars_in_model(self):
 class TestType:
     samplers = (Metropolis, Slice, HamiltonianMC, NUTS)
 
-    def setup_method(self):
-        # save PyTensor config object
-        self.pytensor_config = copy(pytensor.config)
-
-    def teardown_method(self):
-        # restore pytensor config
-        pytensor.config = self.pytensor_config
-
     @pytensor.config.change_flags({"floatX": "float64", "warn_float64": "ignore"})
     def test_float64(self):
         with pm.Model() as model:

tests/variational/test_approximations.py

@@ -84,10 +84,6 @@ def test_scale_cost_to_minibatch_works(aux_total_size):
     y_obs = np.array([1.6, 1.4])
     beta = len(y_obs) / float(aux_total_size)
 
-    # TODO: pytensor_config
-    # with pm.Model(pytensor_config=dict(floatX='float64')):
-    # did not not work as expected
-    # there were some numeric problems, so float64 is forced
     with pytensor.config.change_flags(floatX="float64", warn_float64="ignore"):
         assert pytensor.config.floatX == "float64"
         assert pytensor.config.warn_float64 == "ignore"