Deprecate Model.model property

Author: ricardoV94

pymc/model/core.py

@@ -559,6 +559,7 @@ def __init__(
 
     @property
     def model(self):
+        warnings.warn("Model.model property is deprecated. Just use Model.", FutureWarning)
         return self
 
     @property
@@ -629,7 +630,7 @@ def compile_logp(
             Whether to sum all logp terms or return elemwise logp for each variable.
             Defaults to True.
         """
-        return self.model.compile_fn(self.logp(vars=vars, jacobian=jacobian, sum=sum))
+        return self.compile_fn(self.logp(vars=vars, jacobian=jacobian, sum=sum))
 
     def compile_dlogp(
         self,
@@ -646,7 +647,7 @@ def compile_dlogp(
         jacobian:
             Whether to include jacobian terms in logprob graph. Defaults to True.
         """
-        return self.model.compile_fn(self.dlogp(vars=vars, jacobian=jacobian))
+        return self.compile_fn(self.dlogp(vars=vars, jacobian=jacobian))
 
     def compile_d2logp(
         self,
@@ -663,7 +664,7 @@ def compile_d2logp(
         jacobian:
             Whether to include jacobian terms in logprob graph. Defaults to True.
         """
-        return self.model.compile_fn(self.d2logp(vars=vars, jacobian=jacobian))
+        return self.compile_fn(self.d2logp(vars=vars, jacobian=jacobian))
 
     def logp(
         self,

tests/model/test_core.py

@@ -1107,6 +1107,13 @@ def test_model_pytensor_config():
     assert pytensor.config.mode != "JAX"
 
 
+def test_deprecated_model_property():
+    m = pm.Model()
+    with pytest.warns(FutureWarning, match="Model.model property is deprecated"):
+        m_property = m.model
+    assert m is m_property
+
+
 def test_model_parent_set_programmatically():
     with pm.Model() as model:
         x = pm.Normal("x")