Skip to content

change var to variable #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

change var to variable #512

merged 1 commit into from
Jun 10, 2025

Conversation

williambdean
Copy link
Collaborator

Closes #507

var is already a method of a DataArray so using variable instead allows user to dot into it.

from pymc_extras.prior import Prior

dist = Prior("Normal")
sample: Dataset = dist.sample_prior()
variable = sample.variable

@juanitorduz juanitorduz merged commit 88f0e07 into pymc-devs:main Jun 10, 2025
17 checks passed
andreacate pushed a commit to andreacate/pymc-extras that referenced this pull request Jul 22, 2025
@williambdean @andreacate
change var to variable (pymc-devs#512)
cf00932
andreacate pushed a commit to andreacate/pymc-extras that referenced this pull request Jul 25, 2025
@williambdean @andreacate
change var to variable (pymc-devs#512)
1dc5a4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanitorduz juanitorduz juanitorduz approved these changes

@zaxtax zaxtax Awaiting requested review from zaxtax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default variable name in Prior.sample_prior
2 participants
@williambdean @juanitorduz