update BART example #457
Merged
update BART example #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
OriolAbril
reviewed
Nov 10, 2022
| RANDOM_SEED = 8457 | ||
| rng = np.random.RandomState(RANDOM_SEED) | ||
| RANDOM_SEED = 5781 | ||
| np.random.seed(RANDOM_SEED) |
Member
There was a problem hiding this comment.
I think the global seed doesn't have any effect on v4? if the rng is not used then we can only define the random seed variable to pass to pymc.sample
Member
Author
There was a problem hiding this comment.
I double-checked and it has an effect on BART.
Member
There was a problem hiding this comment.
Should we open an issue on pymc-bart about this and merge in the meantime?
Member
Author
There was a problem hiding this comment.
It is not clear to me what I have to change on pymc-bart, but I will give it a try. Any suggestion is welcome.
OriolAbril
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly reflects changes in the new API.