Add ignored modules to Astroid module deny list #9504
Conversation
jacobtylerwalls
added
the
Needs astroid update
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Great ! Will require an astroid release and upgrade that we could do just for this quickly since the value added is huge.
Work towards #9442
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
👋 @Jamie- I rebased your branch on main after we bumped astroid. Would you have a chance to look into the test failure by any chance? Thank you!
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Pushed a test isolation fix. Thanks again for the PR!
jacobtylerwalls
removed
the
Needs astroid update
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Great change, thank you !
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9504 +/- ##
==========================================
+ Coverage 95.82% 95.83% +0.01%
==========================================
Files 173 174 +1
Lines 18835 18888 +53
==========================================
+ Hits 18049 18102 +53
Misses 786 786
|
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 60add95 |
3 participants
Type of Changes
Description
Adds ignored modules to the Astroid deny list so they may be truly ignored as they will now not be imported at all.
Depends on Astroid change pylint-dev/astroid#2399
Closes #9442